Skip to content

Add VCell Support Role#1536

Merged
Ezequiel-Valencia merged 13 commits intomasterfrom
acl-for-vcell-support
Jun 19, 2025
Merged

Add VCell Support Role#1536
Ezequiel-Valencia merged 13 commits intomasterfrom
acl-for-vcell-support

Conversation

@Ezequiel-Valencia
Copy link
Copy Markdown
Contributor

Made it so that if a user can have the VCell Support role, and view any models shared with VCell Support.

Changes:

  • DB Driver Policy
  • User retrieval functions to return users with their roles
  • Builder classes for User Identity and Special User
  • Grab VCell supports ID on startup
  • A Users roles are passed during communication with clients
  • Tests for every change

@Ezequiel-Valencia
Copy link
Copy Markdown
Contributor Author

Jim Suggestions:

  • Update the startup task to be lazily initialized through local global variable getter
  • Use hashmap for user creation instead of assuming the result is ordered by ID
  • Include roles in the user DTO, such that a separate special user DTO is not required

Copy link
Copy Markdown
Member

@jcschaff jcschaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the most recent changes to consolidate into a single User DTO, looks good, approved.

@Ezequiel-Valencia Ezequiel-Valencia merged commit 37ca2ac into master Jun 19, 2025
13 checks passed
@Ezequiel-Valencia Ezequiel-Valencia deleted the acl-for-vcell-support branch June 19, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create ability for developers to gain VCell Support "Rights" within their account

2 participants