Skip to content

Fix SecurityValidator yaml import crash via lazy dynamic load (#156) #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
virtualian merged 1 commit into from
Apr 26, 2026
Merged

Fix SecurityValidator yaml import crash via lazy dynamic load (#156) #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion Releases/v4.0.3+/.claude/hooks/SecurityValidator.hook.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,22 @@
import { readFileSync, existsSync, writeFileSync, mkdirSync } from 'fs';
import { join } from 'path';
import { homedir } from 'os';
import { parse as parseYaml } from 'yaml';
import type { parse as YamlParse } from 'yaml';
import { configPath, codePath } from './lib/paths';

// Lazy yaml load — static `import 'yaml'` crashes module load when the package
// isn't resolvable from this hook's directory.
let parseYaml: typeof YamlParse | null = null;

async function ensureYamlLoaded(): Promise<void> {
if (parseYaml) return;
try {
parseYaml = (await import('yaml')).parse;
} catch {
parseYaml = null;
}
}

// ========================================
// Security Event Logging
// ========================================
Expand Down Expand Up @@ -220,6 +233,16 @@ function loadPatterns(): PatternsConfig {
};
}

if (!parseYaml) {
return {
version: '0.0',
philosophy: { mode: 'permissive', principle: 'YAML parser unavailable - fail open' },
bash: { trusted: [], blocked: [], confirm: [], alert: [] },
paths: { zeroAccess: [], readOnly: [], confirmWrite: [], noDelete: [] },
projects: {}
};
}

try {
const content = readFileSync(patternsPath, 'utf-8');
patternsCache = parseYaml(content) as PatternsConfig;
Expand Down Expand Up @@ -551,6 +574,7 @@ function handleRead(input: HookInput): void {
// ========================================

async function main(): Promise<void> {
await ensureYamlLoaded();
let input: HookInput;

try {
Expand Down
Loading