fix: respect notifications.voice.enabled setting (#83)#85
Merged
virtualian merged 1 commit intomainfrom Mar 10, 2026
Merged
Conversation
…hook (#83) Voice played despite settings.json having voice.enabled: false because neither voice source checked the setting. Voice server now reads the flag at startup and gates TTS globally. VoiceCompletion hook also checks via existing getSettings() for early exit before HTTP round-trip. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notifications.voice.enabledfrom settings.json at startup and gates all TTS globally — single point of control for ~200 inline curl callersgetSettings()for early exit before HTTP round-trip (belt-and-suspenders)Closes #83
Test plan
/healthreportsvoice_globally_enabled: falsewhen setting is falsecurlwithvoice_enabled: trueproduces no audio when globally disablednotifications.voice.enabled: true🤖 Generated with Claude Code