Skip to content

Conversation

@everthemore
Copy link
Member

No description provided.

@akhmerov
Copy link
Member

BTW, here the code for talking with zoom can be copies almost completely from #5

@everthemore everthemore self-assigned this Sep 30, 2020
@akhmerov
Copy link
Member

akhmerov commented Oct 4, 2020

Let's separate issues, and implement host key rotation separately (I'm looking into that). We'll arrange the sending at a later stage.

@akhmerov
Copy link
Member

akhmerov commented Oct 4, 2020

  • Since the speaker isn't actually the talk host, we should also register the speaker when creating the zoom meeting.

Also if the meeting is configured to send an email upon registration, then participants registered via API will receive a registration confirmation, resulting in the speaker getting 2 emails: one with the host key, and another one with their join URL.

As a workaround we can create the meeting with registrants_email_notification = False, and then set it to True after registering the speaker.

Alternatively we can register the speaker with a wrong email. That's faster, but less classy.

@akhmerov
Copy link
Member

akhmerov commented Oct 7, 2020

@everthemore I pushed the implementation of host key rotation to the repo. host_key_rotation.host_key(timeslot: datetime.datetime) generates the key for a specific time slot.

@akhmerov
Copy link
Member

akhmerov commented Oct 7, 2020

cron runs aren't on yet, but I checked that key updates work.

@akhmerov
Copy link
Member

akhmerov commented Oct 7, 2020

@everthemore the keys are fully in place, and should be easy to reuse. Let's get this one going now.

@akhmerov
Copy link
Member

akhmerov commented Oct 7, 2020

I also put some reusable zoom functionality into common.py

@everthemore
Copy link
Member Author

@akhmerov I added the 'add talk to researchseminars.org' file here too, since it makes sense to do so as soon as the zoom link has been registered.

The code is WIP, meaning that most likely some of the YAML fields are incorrectly named atm. I will fix this before we start testing of course. There are a few places in the code that I would like input on, I'll highlight them in review.

@everthemore
Copy link
Member Author

Closes #20

@everthemore
Copy link
Member Author

I have a temporary bit in there that prevents updating of the yaml file with talks, for the first few tests

@akhmerov
Copy link
Member

akhmerov commented Oct 9, 2020

Plan:

  • Temporarily switch to use a testing branch as a source of talks yml
  • Mock-up the yaml file with testing issue numbers and our emails instead of speaker emails
  • Implement speaker registration
  • Implement email responses
  • Implement issue responses
  • debug so that it runs on the test branch
  • switch to production
  • run it

@everthemore
Copy link
Member Author

everthemore commented Oct 10, 2020

  • Implement email responses

What did you have in mind here? Should this instead be done by the host-key rotator?

@akhmerov
Copy link
Member

Should this instead be done by the host-key rotator?

No, that one runs on schedule and doesn't know whom to contact. We should of course reuse the function that generates the host key for a given time slot, but call if from this workflow.

@everthemore
Copy link
Member Author

Use mailgun?

@everthemore
Copy link
Member Author

@akhmerov Zoom link for meeting is missing, and I'm sure other things are not up to standards. Hopefully I can tweak from here.

@everthemore
Copy link
Member Author

Like adding the time slot to the email

@everthemore
Copy link
Member Author

@akhmerov Merge for testing?

@akhmerov
Copy link
Member

My linter catches a bunch of things, let me fix those first.

@akhmerov
Copy link
Member

I propose to disable research seminars registration at first: it's easier to debug one thing at a time. Plus authorization is missing in one of the function signatures. Other than that I think good to merge and debug.

@everthemore everthemore marked this pull request as ready for review October 11, 2020 15:09
@everthemore everthemore merged commit a85bd3b into master Oct 11, 2020
@everthemore everthemore deleted the schedule-zoom-talks-bot branch October 11, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants