fix(hooks): avoid static useInsertionEffect imports#960
Merged
usefulthink merged 2 commits intovisgl:mainfrom Apr 9, 2026
Merged
fix(hooks): avoid static useInsertionEffect imports#960usefulthink merged 2 commits intovisgl:mainfrom
usefulthink merged 2 commits intovisgl:mainfrom
Conversation
usefulthink
requested changes
Apr 8, 2026
Collaborator
usefulthink
left a comment
usefulthink
left a comment
There was a problem hiding this comment.
Thanks a lot for your contribution, I can see a lot of thought went into this.
I think the test is a bit over the top for this, it essentially just makes sure that this exact change won't be reverted, and introduces a lot of unwanted dependencies (the test-suite shouldn't need the typescript compiler and rollup to run, even if they are coincidentally installed).
Address review feedback: - Replace Reflect.get() with direct property access (React.useInsertionEffect ?? useLayoutEffect) - Remove bundler regression test that introduced heavy test dependencies Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
officialasishkumar
force-pushed
the
fix/use-effect-event-build-compat
branch
from
e16ac85 to
9a4ab5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useInsertionEffectso React 16/17 builds can resolve the module cleanlyuseInsertionEffectdynamically and falling back touseLayoutEffectreactdoes not exportuseInsertionEffectTesting
npx jest src/hooks/__tests__/use-effect-event.test.ts --runInBandnpm run test:tscnpx eslint src/hooks/use-effect-event.ts src/hooks/__tests__/use-effect-event.test.tsCloses #957.