Skip to content

fix: remove development mode#1192

Merged
Thomaash merged 4 commits intomasterfrom
remove-test-leaks
Sep 10, 2025
Merged

fix: remove development mode#1192
Thomaash merged 4 commits intomasterfrom
remove-test-leaks

Conversation

@Thomaash
Copy link
Copy Markdown
Member

This was used to test the internals but generally it's better to test the public API and not poke inside like this. Stripping of the code also broke some time ago and the getters leaking internal state in tests got released in some builds. Now it's all gone.

I hope nobody used this since it got accidentally released to the public. However it's undocumented and prefixed by testLeak, if you depend on something like that 🤷.

closes visjs/vis-timeline#1899

I hope nobody used this since it got accidentally released to the
public. However it's undocumented and prefixed by testLeak, if you
depended on something like that 🤷.
There is no longer any difference between development and production
code.
@Thomaash Thomaash merged commit e23c94c into master Sep 10, 2025
6 checks passed
@Thomaash Thomaash deleted the remove-test-leaks branch September 10, 2025 15:59
@vis-bot
Copy link
Copy Markdown
Collaborator

vis-bot commented Sep 10, 2025

🎉 This PR is included in version 8.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove console.warn from the dist build.

2 participants