Skip to content

feat(generate-examples-index): add okay/fail to stdout#8

Merged
yotamberk merged 1 commit intomasterfrom
which-examples-failed
Jan 12, 2020
Merged

feat(generate-examples-index): add okay/fail to stdout#8
yotamberk merged 1 commit intomasterfrom
which-examples-failed

Conversation

@Thomaash
Copy link
Member

This adds okay to each screenshot that passes the test and fail to each that doesn't. This is handy especially in CI as it's easy to read the stdout but pretty difficult to get the screenshots from there.

Before

 93% - examples/network/data/scalingCustom.html
 95% - examples/network/basic_usage/standalone.html
 96% - examples/network/basic_usage/peer.html
 97% - examples/network/basic_usage/legacy.html
 98% - examples/network/basicUsage.html
100% - examples/network/exampleApplications/worldCupPerformance.html
Screenshot files for 80 written (80 files).

Verification: Only 79 passed (99 %), 1 failed.
This is not within the threshold set by --verify. Exiting with an error.

After

 93% okay - examples/network/data/scalingCustom.html
 95% okay - examples/network/basic_usage/standalone.html
 96% fail - examples/network/basic_usage/peer.html
 97% okay - examples/network/basic_usage/legacy.html
 98% okay - examples/network/basicUsage.html
100% okay - examples/network/exampleApplications/worldCupPerformance.html
Screenshot files for 80 written (80 files).

Verification: Only 79 passed (99 %), 1 failed.
This is not within the threshold set by --verify. Exiting with an error.

This adds okay to each screenshot that passes the test and fail to each
that doesn't. This is handy especially in CI as it's easy to read the
stdout but pretty difficult to get the screenshots from there.
@Thomaash Thomaash requested a review from a team January 12, 2020 18:50
@yotamberk yotamberk merged commit 91c875a into master Jan 12, 2020
@yotamberk yotamberk deleted the which-examples-failed branch January 12, 2020 19:15
@vis-bot
Copy link
Collaborator

vis-bot commented Jan 12, 2020

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants