Skip to content

Component: vf-bookmark#1672

Merged
khawkins98 merged 6 commits intodevelopfrom
component/vf-bookmark
Sep 24, 2021
Merged

Component: vf-bookmark#1672
khawkins98 merged 6 commits intodevelopfrom
component/vf-bookmark

Conversation

@khawkins98
Copy link
Contributor

Creates an initial vf-bookmark with a few options:

  • label_inactive: Add as bookmark
  • label_active: Bookmarked
  • is_active: false
  • modifier: button or inline
  • icon: heart or star

for #1654

Creates an initial vf-bookmark with a few options:

- label_inactive: Add as bookmark
- label_active: Bookmarked
- is_active: false
- modifier: button or inline
- icon: heart or star

for #1654
@khawkins98 khawkins98 self-assigned this Sep 21, 2021
@netlify
Copy link

netlify bot commented Sep 21, 2021

✔️ Deploy Preview for ecstatic-noether-150ab4 ready!

🔨 Explore the source changes: 28d790c

🔍 Inspect the deploy log: https://app.netlify.com/sites/ecstatic-noether-150ab4/deploys/6149ac799e0ab30007243c58

😎 Browse the preview: https://deploy-preview-1672--ecstatic-noether-150ab4.netlify.app

@netlify
Copy link

netlify bot commented Sep 21, 2021

✔️ Deploy Preview for ecstatic-noether-150ab4 ready!

🔨 Explore the source changes: 2154a3c

🔍 Inspect the deploy log: https://app.netlify.com/sites/ecstatic-noether-150ab4/deploys/614e0c5f56f3d7000817d44b

😎 Browse the preview: https://deploy-preview-1672--ecstatic-noether-150ab4.netlify.app

@khawkins98
Copy link
Contributor Author

khawkins98 commented Sep 21, 2021

The first draft of this component is ready for review.

image

Still to do:

  • basic code cleanup
  • accessibility testing
  • more docs and do's don'ts
  • compact version ... is this mobile only?

However this is probably nearly far enough that we can ship it as an alpha for testing in the Training projects.

@khawkins98 khawkins98 marked this pull request as ready for review September 21, 2021 13:49
@khawkins98
Copy link
Contributor Author

Showing sample active/inactive states

image

@khawkins98 khawkins98 merged commit d6e8380 into develop Sep 24, 2021
@khawkins98 khawkins98 deleted the component/vf-bookmark branch September 24, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants