Skip to content

Conversation

@dnth
Copy link
Contributor

@dnth dnth commented Jul 10, 2023

This PR improves the readme page to be more visually appealing and also announces the availability of advanced features for free.

I will re-work the notebooks in another PR.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dnth dnth requested review from amiralush and dbickson July 10, 2023 11:13
README.md Outdated
Sign up for free to be a beta tester and get early access. Drop us an email at info@visual-layer.com .
Learn how to use fastdup as a poweruser!

> **Note**: We have made the decision to offer our advanced features completely free of charge, without requiring a license key. Feel free to try them out and provide us with your valuable [feedback](https://visualdatabase.slack.com/join/shared_invite/zt-19jaydbjn-lNDEDkgvSI1QwbTXSY6dlA#/shared-invite/email)!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dnth let's change this.
We are saying that these are new features out from beta testing.

Also, we have many notebooks, can we arrange them in a 2D grid instead of one by one?
Also, I'd emphasize the new ones first.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I edited the line saying we are releasing the features out from beta testing

Copy link
Contributor Author

@dnth dnth Jul 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with 2D grid for the table and it looks like the following on GitHub.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, it's a little harder to read due to the page width constraint on GitHub. On mobile, it's even harder to read. Do you think we should continue with the 2D grid?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this layout better @amiralush?

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, nope. I don't like this unfortunately. It's hard to read and not sure how much space it saves.

Perhaps let's just half the notebooks icons size. So we could have something like this which is a bit more compact:
Screenshot 2023-07-13 at 22 28 06

I guess that if you reduce the copy size of each example you could do same height (like in what I have attached) and two examples in a single row.

@dnth dnth requested a review from amiralush July 12, 2023 10:05
@dnth
Copy link
Contributor Author

dnth commented Jul 12, 2023

Is this still needed?

image

@amiralush amiralush merged commit 93d787e into visual-layer:main Jul 17, 2023
@dnth dnth deleted the open-access branch July 18, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants