OS-43 many rails version in ci#53
Merged
choosen merged 17 commits intovisualitypl:masterfrom Apr 19, 2021
Merged
Conversation
choosen
force-pushed
the
OS-43_many_rails_version_in_CI
branch
from
bf712d1 to
158a10b
Compare
Fix bundler for rails 4 and bundler audit by separate files
choosen
force-pushed
the
OS-43_many_rails_version_in_CI
branch
from
158a10b to
31e8e52
Compare
choosen
changed the title
Marahin
requested changes
Mar 30, 2021
Collaborator
Marahin
left a comment
Marahin
left a comment
There was a problem hiding this comment.
Overall things look good, well done. I have some minor suggestions left in the comments.
Marahin
requested changes
Apr 19, 2021
Collaborator
Marahin
left a comment
Marahin
left a comment
There was a problem hiding this comment.
Just a tiny suggestion on comments, other than that LGTM! 
Marahin
approved these changes
Apr 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed also problem with spec (rails 4.2 and 6.1) by adding some dummy parameter instead of empty params
Bundle-audit is disabled for rails 4.2 @ CI: Activesupport & actionpack have some flaws there.
based on:
https://www.schneems.com/2021/01/13/migrating-a-ruby-library-from-travisci-to-circleci/
https://circleci.com/blog/circleci-matrix-jobs/
https://circleci.com/docs/2.0/configuration-reference/#matrix-requires-version-21
https://github.com/collectiveidea/audited/blob/master/spec/spec_helper.rb