Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ptbrowne
changed the title
bprusinowski
approved these changes
Nov 23, 2022
Member
bprusinowski
left a comment
bprusinowski
left a comment
There was a problem hiding this comment.
Really nice, the change of keeping interactive filters enabling next to the actual filters makes it much more smooth, I really like this! 👏
I've noticed several things after some testing (using Bathing water quality [with Hierarchie]):
- it's possible to make X field interactive, but nothing happens then (when Date is mapped here),
- when enabling color mapping (Observation Location), it's automatically set as interactive – I am not sure if this is the best approach, taking into consideration the fact that then legend displays as one giant column 😅
- there is still an "Interactive filters" section at the bottom, shouldn't this be removed?
ptbrowne
force-pushed
the
feat/in-place-interactive-filters
branch
from
1d8aca1 to
50ea5f8
Compare
Use same layout for legend and interactive legend Fix #851
ptbrowne
force-pushed
the
feat/in-place-interactive-filters
branch
from
1bde738 to
b933b0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the checkbox for "interactive" from the dedicated "interactive filters" section to the data filters and segment settings. The date filters changes will be in another PR.
How to test