feat: Metadata panel v1#906
Merged
bprusinowski merged 17 commits intomainfrom Nov 28, 2022
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ptbrowne
approved these changes
Nov 23, 2022
Collaborator
ptbrowne
left a comment
ptbrowne
left a comment
There was a problem hiding this comment.
👏 I think we could merge if we used a feature flag to activate / deactivate the button to open the metadata panel ?
| const ToggleButton = ({ onClick }: { onClick: () => void }) => { | ||
| return ( | ||
| <Button component="a" variant="text" size="small" onClick={onClick}> | ||
| <Typography variant="body2">Metadata</Typography> |
Collaborator
There was a problem hiding this comment.
Should this button have a different look when the metadata panel is visible ?
Member
Author
There was a problem hiding this comment.
I think we could maybe make it bold when the panel is open?
cc @AnninaWalker – it's about the button below :)
bprusinowski
force-pushed
the
feat/metadata-panel
branch
from
4de43c2 to
14ecd8c
Compare
ptbrowne
approved these changes
Nov 28, 2022
bprusinowski
force-pushed
the
feat/metadata-panel
branch
from
805e22f to
14ecd8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.