fix(core): allow ctx.rpc.sharedState access during plugin setup (#195)

Author: antfu

packages/core/playground/vite.config.ts

@@ -147,22 +147,34 @@ export default defineConfig({
             initialValue: { count: 1 },
           })
 
-          setInterval(() => {
-            counterState.mutate((current) => {
-              current.count = (current.count + 1) % 5
-            })
-            const count = counterState.value().count
+          counterState.on('updated', (newState) => {
             ctx.docks.update({
               id: 'counter',
               type: 'action',
-              icon: `material-symbols:counter-${count}`,
-              title: `Counter ${count}`,
-              // TODO: HMR?
+              icon: `material-symbols:counter-${newState.count}`,
+              title: `Counter ${newState.count}`,
               action: ctx.utils.createSimpleClientScript(`() => {
-                alert('Counter ${count}')
+                alert('Counter ${newState.count}')
               }`),
             })
-          }, 1000)
+          })
+
+          // setInterval(() => {
+          //   counterState.mutate((current) => {
+          //     current.count = (current.count + 1) % 5
+          //   })
+          //   const count = counterState.value().count
+          //   ctx.docks.update({
+          //     id: 'counter',
+          //     type: 'action',
+          //     icon: `material-symbols:counter-${count}`,
+          //     title: `Counter ${count}`,
+          //     // TODO: HMR?
+          //     action: ctx.utils.createSimpleClientScript(`() => {
+          //       alert('Counter ${count}')
+          //     }`),
+          //   })
+          // }, 1000)
         },
       },
     },

packages/core/src/node/__tests__/host-functions.test.ts

@@ -138,12 +138,12 @@ describe('rpcFunctionsHost', () => {
       })).resolves.toBeUndefined()
     })
 
-    it('should throw in dev mode', async () => {
+    it('should not throw in dev mode when rpc group is not yet set', async () => {
       const host = new RpcFunctionsHost({ mode: 'dev' } as DevToolsNodeContext)
       await expect(host.broadcast({
         method: 'devtoolskit:internal:terminals:updated',
         args: [],
-      })).rejects.toThrow('RpcFunctionsHost] RpcGroup is not set')
+      })).resolves.toBeUndefined()
     })
   })
 

packages/core/src/node/host-functions.ts

@@ -45,11 +45,8 @@ export class RpcFunctionsHost extends RpcFunctionsCollectorBase<DevToolsRpcServe
   >(
     options: RpcBroadcastOptions<T, Args>,
   ): Promise<void> {
-    if (!this._rpcGroup) {
-      if (this.context.mode === 'build')
-        return
-      throw new Error('RpcFunctionsHost] RpcGroup is not set, it likely to be an internal bug of Vite DevTools')
-    }
+    if (!this._rpcGroup)
+      return
 
     debugBroadcast(JSON.stringify(options.method))