Conversation
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-rolldown
@vitejs/devtools-rpc
@vitejs/devtools-self-inspect
commit: |
There was a problem hiding this comment.
Pull request overview
This PR addresses npm installations pulling an incompatible transitive ws version by ensuring @vitejs/devtools-rpc brings its required ws runtime dependency itself (instead of relying on an optional peer).
Changes:
- Move
wsfrompeerDependencies/devDependenciestodependenciesinpackages/rpc. - Update
pnpm-lock.yamlto reflect the dependency graph changes.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/rpc/package.json |
Makes ws a direct runtime dependency of @vitejs/devtools-rpc so the WS server preset reliably has a compatible ws version installed. |
pnpm-lock.yaml |
Updates lockfile to match the new dependency placement and resulting resolution graph. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| '@vitejs/devtools@0.1.13': | ||
| resolution: {integrity: sha512-0PWKOrYyDiP+UFI0Sfqn3uTxRwQMnvFyA6t4vnj+0SpCEk+XNEP2igqjCp7/F9wU0JDH3SiWhfMe41za9BtwkA==} | ||
| hasBin: true | ||
| peerDependencies: | ||
| vite: ^8.0.3 |
There was a problem hiding this comment.
pnpm-lock.yaml now includes a resolved registry package @vitejs/devtools@0.1.13 (and nearby @vitejs/devtools-* entries). For a PR that only moves ws from peer/dev deps to deps in packages/rpc, this looks like unrelated lockfile churn and may cause local tooling to resolve the published package instead of the workspace one. Consider regenerating the lockfile to keep workspace packages linked where possible (or document why these registry entries are expected).
Close #280