Skip to content

fix(rpc): move ws to dependencies#286

Open
webfansplz wants to merge 1 commit intomainfrom
fix-rpc-deps
Open

fix(rpc): move ws to dependencies#286
webfansplz wants to merge 1 commit intomainfrom
fix-rpc-deps

Conversation

@webfansplz
Copy link
Copy Markdown
Member

Close #280

Copilot AI review requested due to automatic review settings April 10, 2026 15:28
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 10, 2026

Open in StackBlitz

@vitejs/devtools

npm i https://pkg.pr.new/@vitejs/devtools@286

@vitejs/devtools-kit

npm i https://pkg.pr.new/@vitejs/devtools-kit@286

@vitejs/devtools-rolldown

npm i https://pkg.pr.new/@vitejs/devtools-rolldown@286

@vitejs/devtools-rpc

npm i https://pkg.pr.new/@vitejs/devtools-rpc@286

@vitejs/devtools-self-inspect

npm i https://pkg.pr.new/@vitejs/devtools-self-inspect@286

commit: ae85f93

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses npm installations pulling an incompatible transitive ws version by ensuring @vitejs/devtools-rpc brings its required ws runtime dependency itself (instead of relying on an optional peer).

Changes:

  • Move ws from peerDependencies/devDependencies to dependencies in packages/rpc.
  • Update pnpm-lock.yaml to reflect the dependency graph changes.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/rpc/package.json Makes ws a direct runtime dependency of @vitejs/devtools-rpc so the WS server preset reliably has a compatible ws version installed.
pnpm-lock.yaml Updates lockfile to match the new dependency placement and resulting resolution graph.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +3752 to +3756
'@vitejs/devtools@0.1.13':
resolution: {integrity: sha512-0PWKOrYyDiP+UFI0Sfqn3uTxRwQMnvFyA6t4vnj+0SpCEk+XNEP2igqjCp7/F9wU0JDH3SiWhfMe41za9BtwkA==}
hasBin: true
peerDependencies:
vite: ^8.0.3
Copy link

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpm-lock.yaml now includes a resolved registry package @vitejs/devtools@0.1.13 (and nearby @vitejs/devtools-* entries). For a PR that only moves ws from peer/dev deps to deps in packages/rpc, this looks like unrelated lockfile churn and may cause local tooling to resolve the published package instead of the workspace one. Consider regenerating the lockfile to keep workspace packages linked where possible (or document why these registry entries are expected).

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect version of "ws" dependency pulled by npm

2 participants