Skip to content

fix(rolldown): plugin details virtual list scrolling#287

Merged
webfansplz merged 2 commits intomainfrom
fix/plugin-flow-scroll
Apr 14, 2026
Merged

fix(rolldown): plugin details virtual list scrolling#287
webfansplz merged 2 commits intomainfrom
fix/plugin-flow-scroll

Conversation

@webfansplz
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings April 14, 2026 17:15
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 14, 2026

Open in StackBlitz

@vitejs/devtools

npm i https://pkg.pr.new/@vitejs/devtools@287

@vitejs/devtools-kit

npm i https://pkg.pr.new/@vitejs/devtools-kit@287

@vitejs/devtools-rolldown

npm i https://pkg.pr.new/@vitejs/devtools-rolldown@287

@vitejs/devtools-rpc

npm i https://pkg.pr.new/@vitejs/devtools-rpc@287

@vitejs/devtools-self-inspect

npm i https://pkg.pr.new/@vitejs/devtools-self-inspect@287

commit: cf8a1c4

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes scrolling behavior for the Plugin Details “virtual list” by moving the table header into the scroller’s before slot and ensuring the scroller uses container-based scrolling (not page-mode) within a flex layout.

Changes:

  • Extend DataVirtualList to support a before slot and a configurable pageMode prop (defaulting to true).
  • Update plugin flow layout containers to use min-h-0 to allow the virtual scroller to size/scroll correctly within flex.
  • Refactor PluginDetailsTable to render the header via DataVirtualList’s before slot, disable page-mode scrolling, and apply sticky positioning for the header.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/ui/src/components/DataVirtualList.vue Adds pageMode prop and before slot support; adjusts scroller slot structure.
packages/rolldown/src/app/components/flowmap/PluginFlow.vue Tweaks flex/height/overflow-related classes to support nested virtual scrolling.
packages/rolldown/src/app/components/data/PluginDetailsTable.vue Moves header into before slot, disables page-mode, and adds sticky styling for header.
Comments suppressed due to low confidence (1)

packages/ui/src/components/DataVirtualList.vue:20

  • DataVirtualList passes a key slot prop (v-bind="{ key: ... }"), but defineSlots does not include key in the default slot’s typed props. This makes the component’s slot API/type definition inconsistent and will prevent consumers from using { key } without TS errors. Either add key to the default slot prop typing (ideally typed to the item’s key field) or stop passing key as a slot prop if it isn’t intended to be part of the public slot API.
defineSlots<{
  before?: () => void
  default: (props: {
    item: T
    index: number
    active?: boolean
  }) => void
}>()

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@webfansplz webfansplz merged commit e155095 into main Apr 14, 2026
13 checks passed
@webfansplz webfansplz deleted the fix/plugin-flow-scroll branch April 14, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants