fix(rolldown): plugin details virtual list scrolling#287
Merged
webfansplz merged 2 commits intomainfrom Apr 14, 2026
Merged
Conversation
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-rolldown
@vitejs/devtools-rpc
@vitejs/devtools-self-inspect
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes scrolling behavior for the Plugin Details “virtual list” by moving the table header into the scroller’s before slot and ensuring the scroller uses container-based scrolling (not page-mode) within a flex layout.
Changes:
- Extend
DataVirtualListto support abeforeslot and a configurablepageModeprop (defaulting totrue). - Update plugin flow layout containers to use
min-h-0to allow the virtual scroller to size/scroll correctly within flex. - Refactor
PluginDetailsTableto render the header viaDataVirtualList’sbeforeslot, disable page-mode scrolling, and apply sticky positioning for the header.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/ui/src/components/DataVirtualList.vue | Adds pageMode prop and before slot support; adjusts scroller slot structure. |
| packages/rolldown/src/app/components/flowmap/PluginFlow.vue | Tweaks flex/height/overflow-related classes to support nested virtual scrolling. |
| packages/rolldown/src/app/components/data/PluginDetailsTable.vue | Moves header into before slot, disables page-mode, and adds sticky styling for header. |
Comments suppressed due to low confidence (1)
packages/ui/src/components/DataVirtualList.vue:20
DataVirtualListpasses akeyslot prop (v-bind="{ key: ... }"), butdefineSlotsdoes not includekeyin thedefaultslot’s typed props. This makes the component’s slot API/type definition inconsistent and will prevent consumers from using{ key }without TS errors. Either addkeyto thedefaultslot prop typing (ideally typed to the item’s key field) or stop passingkeyas a slot prop if it isn’t intended to be part of the public slot API.
defineSlots<{
before?: () => void
default: (props: {
item: T
index: number
active?: boolean
}) => void
}>()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.