Migration from v5 #1548
Merged
Migration from v5 #1548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitejs-docs-ja ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shuuji3
reviewed
Sep 22, 2024
Contributor
shuuji3
left a comment
shuuji3
left a comment
There was a problem hiding this comment.
guide/migration.md をレビューしてみましたが、完璧な翻訳でした。あとは docs/.vitepress/config.ts を更新するだけでマージできそうですね。
Collaborator
Author
|
@shuuji3 おぉ、レビューありがとうございます！ 🙇
|
Contributor
|
もとのIssue #1538 の commit (vitejs/vite@242f550#diff-3def678deb1b1d5a53948eb8491817dde4dc881e032e785fc61cc93d334eefcd) で |
shuuji3
approved these changes
Sep 22, 2024
# Conflicts: # guide/migration.md
Collaborator
Author
|
migration.md に関する issue が多くなってきたのでマージしてしまう |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #1538 resolve #1646 resolve #1653 resolve #1659
の反映です