fix: Include renderBuiltUrl contents in JS + CSS chunk hashes#21433
Draft
hartz89 wants to merge 2 commits intovitejs:mainfrom
Draft
fix: Include renderBuiltUrl contents in JS + CSS chunk hashes#21433hartz89 wants to merge 2 commits intovitejs:mainfrom
hartz89 wants to merge 2 commits intovitejs:mainfrom
Conversation
hartz89
changed the title
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13996 by including
renderBuiltUrlcontents in JS chunk hashes by adding anaugmentChunkHashhook to thevite:build-import-analysisplugin that includes the stringified representation of therenderBuiltUrlfunction in the hash calculation.It also solves the same issue for CSS chunk hashes by salting the CSS source with the
renderBuiltUrlconfiguration before it gets emitted.This is my first Vite PR so I'm sure I'm missing some components, but I'll continue to iterate on it as I gather immediate feedback on the approach.