-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
docs: add Scrimba tutorial links across documentation #21467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add a ScrimbaLink component and integrate 8 tutorial links into the docs: - Getting Started page - Features (TypeScript and Static Assets sections) - Env Variables and Modes - Building for Production - Configuring Vite - Using Plugins - Server-Side Rendering
sapphi-red
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a heads-up, we are planning to update the template within the next month (#21425), so it may be a good idea to make further updates to the lesson after that.
docs/guide/features.md
Outdated
|
|
||
| Vite supports importing `.ts` files out of the box. | ||
|
|
||
| <ScrimbaLink href="https://scrimba.com/intro-to-vite-c03p6pbbdq/~0t6?via=vite" title="TypeScript in Vite">Watch an interactive lesson on Scrimba</ScrimbaLink> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this lesson is outdated. vite-env.d.ts is not included in the template any more as we now include the equivalent in tsconfig.json.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, then I'll wait with this link until we've updated the underlying scrim.
Co-authored-by: 翠 <green@sapphi.red>
- Move config ScrimbaLink below --config code block - Move env-and-mode ScrimbaLink below Example block - Remove outdated TypeScript ScrimbaLink - Move scaffolding ScrimbaLink from ssr.md to index.md Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Thanks for the feedback @sapphi-red ! I've implemented all your requested changes. Let me know how it looks :) |
sapphi-red
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Co-authored-by: Per Harald Borgen <perharaldborgen@MacBook-Pro-2.local> Co-authored-by: 翠 <green@sapphi.red> Co-authored-by: Per Harald Borgen <perharaldborgen@MacBook-Pro-2.lan> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This PR adds a ScrimbaLink component and uses it to integrate relevant tutorial links into the docs, as discussed with and agreed by @yyx990803 .
Here are the locations of the links: