fix: align the Plugin type with rollup (fix #21715)#21722
Open
jendrikw wants to merge 1 commit intovitejs:mainfrom
Open
fix: align the Plugin type with rollup (fix #21715)#21722jendrikw wants to merge 1 commit intovitejs:mainfrom
jendrikw wants to merge 1 commit intovitejs:mainfrom
Conversation
Author
|
Seems like the switch to rolldown introduces another wall of errors. Is there a way to get this merges and released for version 7? |
Member
|
Yeah I think we can accept a backport on the v7 branch for this type fix |
Author
|
I won't be able to work on this until next monday, but these changes on version 7.3.1 worked for me: https://gitlab1.ptb.de/digitaldynamicmeasurement/dccviewer-js/-/blob/bf40abdcfb3e253e92c2366bcfcd125d35ace1eb/patches/vite+7.3.1.patch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't find an easy way to test this change without also enabling
strictOptionalPropertyTypesfor the whole project.