docs: fix optimizeDeps type links#21823
Merged
Merged
Conversation
Member
I think you saw the wrong one. vite/packages/vite/src/node/optimizer/index.ts Lines 91 to 104 in d1bcc91 |
Member
Author
|
Indeed I was 🤦 fixed now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently they look a bit weird, https://main.vite.dev/config/dep-optimization-options#optimizedeps-rolldownoptions:
This PR fixes it:
I've updated theesbuildOptionsto use the same type asrolldownOptionsas that's what it is internally now. Not sure if it's intended to reference the old type.I also removed the link to
Omitsince I think it's not necessary to link typescript builtins, and we have other types not linking it as well. Happy to revert that if we feel otherwise.