fix(create-vite): handle double dash for npm exec#21830
Merged
sapphi-red merged 1 commit intoMar 12, 2026
Merged
Conversation
sapphi-red
added
p3-minor-bug
bluwy
approved these changes
Mar 12, 2026
| .replace(/^npm exec (?:-- )?/, () => { | ||
| // Prefer `pnpm dlx`, `yarn dlx`, or `bun x` | ||
| if (pkgManager === 'pnpm') { | ||
| // pnpm doesn't support the -- syntax |
Member
There was a problem hiding this comment.
Not sure if we need this comment as the other pms are also handled this way
Member
Author
There was a problem hiding this comment.
yarn and bun supports -- so we don't have to remove for them
Member
There was a problem hiding this comment.
But with the regex we're removing it anyways no?
Member
Author
There was a problem hiding this comment.
we are, but we don't have to. The comment is to tell that it is necessary for pnpm.
Member
There was a problem hiding this comment.
Ok, I think I was confused that the comment is about the "pnpm dlx " but it's only a note comment in general and not about the string.
Not really a big deal either ways.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #21614
close #21648