fix: hmrClient.logger.debug and hmrClient.logger.error looked different from other HMR logs#22147
fix: hmrClient.logger.debug and hmrClient.logger.error looked different from other HMR logs#22147Bryasxin wants to merge 3 commits intovitejs:mainfrom
hmrClient.logger.debug and hmrClient.logger.error looked different from other HMR logs#22147Conversation
…ferent from other HMR logs (vitejs#22146)
bluwy
left a comment
There was a problem hiding this comment.
@sheremet-va It'd be nice to have your input here since you've abstracted the logger before in #15631
The idea makes sense to me to have the logs show consistently, but does this change make sense in general for the logger? And is it normal for hmrLogger.debug to be printed out by default?
|
I confirmed that Not sure if that's the intended behavior, should it be gated behind a lower log level? |
|
I thought it's not even working by default for the SSR environment 🤔 |
The implementation just copies how it works in the browser. There it calls |
|
We have debug logging using the Anyways this is a bigger change, and if this PR looks good to you, then I think we can go with this first. Maybe we want to revisit this before the environment api goes stable. |
fixes #22146