fix(create-vite): add missing quotes around viteLogo src attribute#22216
Merged
bluwy merged 4 commits intovitejs:mainfrom Apr 14, 2026
Merged
fix(create-vite): add missing quotes around viteLogo src attribute#22216bluwy merged 4 commits intovitejs:mainfrom
bluwy merged 4 commits intovitejs:mainfrom
Conversation
bluwy
reviewed
Apr 13, 2026
bluwy
added a commit
to bluwy/create-vite-extra
that referenced
this pull request
Apr 13, 2026
bluwy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
srcattribute forviteLogoin the vanilla template was missing quotes around the template literal interpolation.Before:
After:
This makes it consistent with the other two image tags in the same block and ensures valid HTML attribute syntax.