docs: link to @oxc-project/fast-glob for import.meta.glob pattern syntax#22282
Draft
shulaoda wants to merge 1 commit into
Draft
docs: link to @oxc-project/fast-glob for import.meta.glob pattern syntax#22282shulaoda wants to merge 1 commit into
shulaoda wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import.meta.globdocs (docs/guide/features.md) to point users to@oxc-project/fast-globinstead oftinyglobby.superchupu.dev/tinyglobby/comparisonlink and lets readers consult the upstream project directly for the list of supported glob patterns.Motivation
Vite's build is moving onto Rolldown, whose native
import.meta.globplugin matches patterns with@oxc-project/fast-globrather thantinyglobby.@oxc-project/fast-globintentionally drops extglob support, so the set of valid patterns users can write differs from whattinyglobby's docs advertise. Going forward, the same matcher will be exposed to the JS side via a napi binding so dev and build share one implementation — pointing users at the oxc repo now keeps the documented syntax consistent with the matcher they will actually hit.Scope
Docs-only change. The JS-side implementation in
packages/vite/src/node/plugins/importMetaGlob.tsstill imports fromtinyglobby; swapping it to the upcoming napi binding will land in a follow-up. Similar links elsewhere (optimizeDeps.entries,server.warmup) were intentionally left alone since they describe different features and are not affected by the Rolldown migration.