fix(resolve): fall back to module entry when browser entry is non-ESM in build#22295
Closed
semimikoh wants to merge 1 commit intovitejs:mainfrom
Closed
fix(resolve): fall back to module entry when browser entry is non-ESM in build#22295semimikoh wants to merge 1 commit intovitejs:mainfrom
semimikoh wants to merge 1 commit intovitejs:mainfrom
Conversation
Member
|
Thanks for the PR, but this is an expected behavior: #22285 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… in build
Summary
roughjs@4.5.2havebrowserpointing to an IIFE bundle andmodulepointing to ESM, with noexportsfieldbrowserentry first, which has no ESM exports →MISSING_EXPORTerrortryResolveBrowserEntryalready has a heuristic (hasESMSyntaxcheck) to fall back tomodulewhenbrowseris non-ESM, but itwasn't being used during Rolldown builds
oxcResolvePluginthat intercepts these cases and routes through Vite's resolverTest plan
@visactor/vrender-kits→roughjs@4.5.2)Fixes #22285