fix(build): copy public directory after building same environment with write=false#22328
Merged
sapphi-red merged 2 commits intoMay 14, 2026
Merged
Conversation
ec8e139 to
c48b58b
Compare
c48b58b to
05be609
Compare
05be609 to
6df7ba6
Compare
Contributor
Author
|
@bluwy hi, quick check: is this still worth a look? CI is green now. happy to adjust if you’d prefer a different approach. |
write=false
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #22305
prepareOutDirPluginwas marking an environment as rendered even whenbuild.writewas false. If the same environment was built again withwriteset back to true,prepareOutDir()was skipped andpublicDirwas not copied.This only marks the environment as rendered when
prepareOutDir()actually runs.Added a regression test for building the same client environment with
write: falsefirst andwrite: truesecond.Checks:
pnpm --filter vite buildpnpm test-unit buildpnpm --filter vite typecheckpnpm exec eslint --cache --concurrency auto packages/vite/src/node/plugins/prepareOutDir.ts packages/vite/src/node/__tests__/build.spec.ts