fix(optimizer): pass oxc jsx options to transformSync in dependency scan #22342
Open
semimikoh wants to merge 1 commit intovitejs:mainfrom
Open
fix(optimizer): pass oxc jsx options to transformSync in dependency scan #22342semimikoh wants to merge 1 commit intovitejs:mainfrom
semimikoh wants to merge 1 commit intovitejs:mainfrom
Conversation
The `doTransformGlobImport` function in the dependency scanner was calling `transformSync` without passing user-configured OXC transform options. This caused custom JSX settings (e.g. importSource, pragma, runtime) to be ignored during scan, resulting in incorrect dependency resolution such as attempting to resolve `react/jsx-runtime` instead of the configured custom JSX runtime. Fix vitejs#22340
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
doTransformGlobImportfunction in the dependency scanner was callingtransformSyncwithout passing user-configured OXC transform options. This caused custom JSX settings (e.g. importSource, pragma, runtime) to be ignored during scan, resulting in incorrect dependency resolution such as attempting to resolvereact/jsx-runtimeinstead of the configured custom JSX runtime.Fix #22340
Summary
doTransformGlobImportinscan.tswas callingtransformSyncwith onlylangandtsconfig, ignoring user-configuredoxc.jsxoptions
getOxcTransformOptions()helper to extract transform-relevant options fromconfig.oxcRelated
Fixes #22340
Test plan
import.meta.globscan respects custom oxc jsx options (e.g.importSource: 'vue'resolvesvue/jsx-dev-runtimeinstead ofreact/jsx-runtime)