feat(optimizer): improve the esbuild plugin converter to pass some properties of build result to onEnd#22357
Merged
sapphi-red merged 4 commits intoMay 14, 2026
Conversation
onEnd
onEndonEnd
Member
|
I've kept |
sapphi-red
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #22356.
convertEsbuildPluginToRolldownPlugin()currently passes a throwing proxy to esbuildonEndcallbacks. That means normal esbuild-style code such asif (!result.metafile) returnthrows instead of seeingundefinedwhen no metafile is available.This PR passes a minimal valid
esbuild.BuildResultinstead, with emptyerrorsandwarningsand optional result fields set toundefined.Tests
pnpm exec vitest run packages/vite/src/node/__tests__/optimizer/pluginConverter.spec.tspnpm exec vitest run packages/vite/src/node/__tests__/optimizerpnpm exec eslint --cache --concurrency auto packages/vite/src/node/optimizer/pluginConverter.ts packages/vite/src/node/__tests__/optimizer/pluginConverter.spec.tspnpm exec oxfmt --check packages/vite/src/node/optimizer/pluginConverter.ts packages/vite/src/node/__tests__/optimizer/pluginConverter.spec.tspnpm --filter vite typecheck