Skip to content

fix(create-vite): pass react framework to TanStack CLI#22397

Merged
sapphi-red merged 1 commit intovitejs:mainfrom
WaryaWayne:codex/create-vite-tanstack-react-framework
May 8, 2026
Merged

fix(create-vite): pass react framework to TanStack CLI#22397
sapphi-red merged 1 commit intovitejs:mainfrom
WaryaWayne:codex/create-vite-tanstack-react-framework

Conversation

@WaryaWayne
Copy link
Copy Markdown
Contributor

I used create-vite@latest to create a React project with TanStack Router. After selecting React in Vite, the TanStack CLI asks for the framework again because Vite does not pass --framework react to the CLI.

The Solid TanStack Router option already passes --framework solid, so this updates the React option to pass --framework react as well.

No linked issue; this appears to be caused by a recent TanStack CLI behavior change.

Tests:

  • pnpm --filter create-vite typecheck
  • pnpm --filter create-vite build

@sapphi-red sapphi-red added p3-minor-bug An edge case that only affects very specific usage (priority) feat: create-vite create-vite package labels May 8, 2026
Copy link
Copy Markdown
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sapphi-red sapphi-red merged commit 18f0f90 into vitejs:main May 8, 2026
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat: create-vite create-vite package p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants