Skip to content

build: replace deprecated onwarn with onLog#22741

Merged
sapphi-red merged 3 commits into
vitejs:mainfrom
btea:refactor/replace-onwarn-with-onlog
Jul 6, 2026
Merged

build: replace deprecated onwarn with onLog#22741
sapphi-red merged 3 commits into
vitejs:mainfrom
btea:refactor/replace-onwarn-with-onlog

Conversation

@btea

@btea btea commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@sapphi-red

Copy link
Copy Markdown
Member

Would you split this into two PRs?

@btea

btea commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Sure, I will split this into two PRs.

Comment thread packages/vite/src/node/cli.ts
@sapphi-red sapphi-red changed the title refactor(build): replace deprecated onwarn with onLog in rolldown config build: replace deprecated onwarn with onLog in rolldown config Jul 6, 2026
@sapphi-red sapphi-red changed the title build: replace deprecated onwarn with onLog in rolldown config build: replace deprecated onwarn with onLog Jul 6, 2026
@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Jul 6, 2026

@sapphi-red sapphi-red left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sapphi-red sapphi-red merged commit c581b55 into vitejs:main Jul 6, 2026
22 checks passed
@btea btea deleted the refactor/replace-onwarn-with-onlog branch July 6, 2026 10:55
@btea

btea commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

The Circular dependency warning message appears to be a legacy issue, but it doesn't seem to exist now. Perhaps we can simply remove onLog. @sapphi-red

@sapphi-red

Copy link
Copy Markdown
Member

Ah, maybe because https://rolldown.rs/reference/InputOptions.checks#circulardependency is disabled by default. If that's the case, we can simply remove it.

@btea

btea commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Yes, local testing confirms this. Setting checks.circularDependency to true does indeed output multiple circular dependency warnings during the build process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1-chore Doesn't change code behavior (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants