feat!: inline @vitest/runner package, do not publish it anymore#10511
Merged
Conversation
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
hi-ogawa
reviewed
Jun 3, 2026
Collaborator
hi-ogawa
left a comment
There was a problem hiding this comment.
Looks clean to me.
Can we dedupe this copy of generateFileHash now?
vitest/packages/browser/src/client/orchestrator.ts
Lines 484 to 502 in 680ac2e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package is very tightly connected to Vitest and is not used outside of
vitest. We had to develop a lot of hacky workaround to augment types or pass down objects in a strange way to keep it agnostic, but the benefits do not outweght the negatives at this point.The
runnerconfig option still works the same way as it did before, the public types are also not touched. This is mostly a refactor change.TODO:
createFileTask) since these modules are also used on node side