Skip to content

feat!: inline @vitest/runner package, do not publish it anymore#10511

Merged
sheremet-va merged 12 commits into
mainfrom
feat/remove-runner=package
Jun 3, 2026
Merged

feat!: inline @vitest/runner package, do not publish it anymore#10511
sheremet-va merged 12 commits into
mainfrom
feat/remove-runner=package

Conversation

@sheremet-va
Copy link
Copy Markdown
Member

@sheremet-va sheremet-va commented Jun 2, 2026

This package is very tightly connected to Vitest and is not used outside of vitest. We had to develop a lot of hacky workaround to augment types or pass down objects in a strange way to keep it agnostic, but the benefits do not outweght the negatives at this point.

The runner config option still works the same way as it did before, the public types are also not touched. This is mostly a refactor change.

TODO:

  • Make utils modules not be bundled together with the runner (like createFileTask) since these modules are also used on node side

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 2, 2026

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 35802ac
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/6a1f0e8d54910f0008f64c44
😎 Deploy Preview https://deploy-preview-10511--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@sheremet-va sheremet-va requested a review from hi-ogawa June 2, 2026 19:11
Copy link
Copy Markdown
Collaborator

@hi-ogawa hi-ogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean to me.

Can we dedupe this copy of generateFileHash now?

// TODO: copied from packages/runner/src/utils/collect.ts
interface HashMeta {
typecheck?: boolean
__vitest_label__?: string
}
function generateFileHash(
file: string,
projectName: string | undefined,
meta?: HashMeta,
): string {
const seed = [
file,
projectName || '',
meta?.typecheck ? '__typecheck__' : '',
meta?.__vitest_label__ || '',
].join('\0')
return generateHash(seed)
}

@sheremet-va sheremet-va merged commit 6d6e46b into main Jun 3, 2026
8 checks passed
@sheremet-va sheremet-va deleted the feat/remove-runner=package branch June 3, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants