[Fix] Resolve SSH Directory Issue#1054
Merged
saeedvaziry merged 2 commits intovitodeploy:3.xfrom Mar 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix failures when executing SSH commands as an isolated site user by ensuring the command runs from that user’s home directory (instead of inheriting the SSH login user’s working directory).
Changes:
- Prepends a
cd /home/<asUser>before runningsudo -u <asUser> bashinSSH::exec()to adjust the working directory for commands executed as another user.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Grumble grumble, copilot came up with a better solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a minor change to the
execmethod inapp/Helpers/SSH.phpto improve command execution context. The update ensures that commands run as a specific user are executed from the user's home directory.cd /home/{$this->asUser}statement before executing commands as the specified user, ensuring the working directory is set appropriately.Resolves #1045
Resolves #1034