Dev by vitorhugo-java · Pull Request #31 · vitorhugo-java/SpringAPI_EspacoGeek

vitorhugo-java · 2026-02-19T11:31:23Z

No description provided.

@slf4j

Replace in-memory JSONArray readers with streaming BufferedReader-based readers for movies and series to avoid loading entire payloads into memory. Each reader now consumes an InputStream from MediaApi, parses one JSON object per line with JSONParser, tracks currentLine for checkpointing in ExecutionContext, skips already-processed lines on open, and closes the reader in close(). Added @slf4j logging and improved error logs. Also changed DelayChunkListener log level from INFO to DEBUG for the post-chunk delay message.

Add stream-based TMDB fetching and update readers: MediaApi gained updateTitlesStream(), MovieAPIImpl and TvSeriesApiImpl now return a GZIP InputStream with retry semantics. DataJumpUtils was refactored to expose getDataJumpTMDBStream(...) (returning an uncompressed GZIP InputStream) and to rebuild getDataJumpTMDBArray(...) by reading/parsing the stream line-by-line into a JSONArray with improved error handling. MovieJsonReader and SerieJsonReader now consume the JSONArray in-memory with index-based checkpointing instead of line-based BufferedReader parsing; update() persists nextIndex. Also changed DelayChunkListener logging from debug to info and expanded .gitignore entries. These changes centralize HTTP/stream handling, add better retry/error handling, and simplify JSON reader logic.

@SuppressWarnings

Replace bitwise & with logical && in MediaController input checks to correctly evaluate null/empty name conditions. In MediaServiceImpl, avoid casting Optional to Page when an id is provided: assemble a single-element list, use PageImpl and a safe pageable fallback so single-result queries behave like paged results. Add @SuppressWarnings where needed. Change artwork refresh loop to call MediaUtils.updateMediaWhenLastTimeUpdateMoreThanOneDay(...) before switching and add break statements to prevent fall-through. Make MediaUtils.updateMediaWhenLastTimeUpdateMoreThanOneDay public so it can be reused. Minor cleanup of an extraneous comment.

github-actions · 2026-02-19T11:34:08Z

Qodana for JVM

42 new problems were found

Inspection name	Severity	Problems
`Unused assignment`	🔶 Warning	16
`Constant values`	🔶 Warning	6
`String comparison using '==', instead of 'equals()'`	🔶 Warning	5
`Optional.get() is called without isPresent() check`	🔶 Warning	4
`Boxing of already boxed value`	🔶 Warning	2
`Mismatched query and update of collection`	🔶 Warning	2
`AutoCloseable used without 'try'-with-resources`	🔶 Warning	1
`Nullability and data flow problems`	🔶 Warning	1
`Result of method call ignored`	🔶 Warning	1
`'long' literal ending with 'l' instead of 'L'`	🔶 Warning	1
`Use of Optional.ofNullable with null or non-null argument`	🔶 Warning	1
`Single character alternation`	🔶 Warning	1
`'if' statement with identical branches or common parts`	◽️ Notice	1

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

Register at Qodana Cloud and configure the action
Use GitHub Code Scanning with Qodana
Host Qodana report at GitHub Pages
Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2025.3.1
        with:
          upload-result: true

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

Copilot

Pull request overview

This PR refactors TMDB “datajump” export fetching to support streaming, fixes several media lookup/pagination paths that previously performed invalid casts, and reduces unnecessary artwork refreshes by gating updates based on last-update age.

Changes:

Add a streaming TMDB daily export fetch path (getDataJumpTMDBStream) and expose it through MediaApi.updateTitlesStream() with implementations for movies and TV series.
Fix find*ByIdOrName methods to return a proper Page (via PageImpl) instead of an invalid cast from Optional.
Only update artworks in mountMediaPage when media hasn’t been updated in more than one day; also fix switch fall-through by adding breaks.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
`src/main/java/com/espacogeek/geek/utils/MediaUtils.java`	Exposes the “updated more than one day ago” predicate for reuse outside the utility class.
`src/main/java/com/espacogeek/geek/utils/DataJumpUtils.java`	Introduces TMDB export streaming + refactors array-building to read line-by-line from a stream.
`src/main/java/com/espacogeek/geek/services/impl/MediaServiceImpl.java`	Fixes ID-lookup pagination and gates artwork refreshes by last-update time.
`src/main/java/com/espacogeek/geek/data/api/impl/TvSeriesApiImpl.java`	Implements `updateTitlesStream()` for series exports.
`src/main/java/com/espacogeek/geek/data/api/impl/MovieAPIImpl.java`	Implements `updateTitlesStream()` for movie exports.
`src/main/java/com/espacogeek/geek/data/api/MediaApi.java`	Adds a default `updateTitlesStream()` API.
`src/main/java/com/espacogeek/geek/controllers/MediaController.java`	Replaces bitwise `&` with logical `&&` in input validation checks.
`src/main/java/com/espacogeek/geek/controllers/BatchController.java`	Fixes the role name used to authorize stopping batch jobs.
`.gitignore`	Adds ignores for environment/secrets, node modules, logs, and local AIOS files.

Comments suppressed due to low confidence (1)

src/main/java/com/espacogeek/geek/utils/DataJumpUtils.java:58

The TMDB export URL is using plain HTTP. This allows MITM tampering of the gzipped JSON feed; switch to HTTPS for the files.tmdb.org export endpoint if supported.

            request = new Request.Builder()
                    .url(MessageFormat.format("http://files.tmdb.org/p/exports/{3}_ids_{0}_{1}_{2}.json.gz", month, day, year, type.getValue()))
                    .method("GET", null)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-19T11:37:09Z

        Response response = null;
        try {
            response = client.newCall(request).execute();
+            if (!response.isSuccessful()) {
+                log.error("Failed to fetch TMDB daily export: {}", response.message());
+                response.close();
+                throw new com.espacogeek.geek.exception.RequestException();
+            }
+            assert response.body() != null;
+            return new GZIPInputStream(response.body().byteStream());
        } catch (IOException e) {


getDataJumpTMDBStream returns a stream backed by an OkHttp Response, but the Response is never closed on the success path. This will leak connections/sockets unless the response is reliably closed when the returned stream is closed; consider wrapping the returned InputStream so close() also closes the OkHttp Response (and replace the assert response.body() != null with an explicit null check that throws a RequestException).

Copilot · 2026-02-19T11:37:09Z

            }
-            jsonArray.add(jsonObject);
+        } catch (Exception e) {
+            log.error("Error reading TMDB array: {}", e.getMessage());


getDataJumpTMDBArray is annotated with @Retryable(...RequestException.class) but the outer catch (Exception e) swallows failures and returns a partial/empty array, which prevents retries and hides errors from callers. Re-throw a RequestException (or let it propagate) after logging so retry semantics work as intended.

Suggested change

log.error("Error reading TMDB array: {}", e.getMessage());

log.error("Error reading TMDB array", e);

throw new com.espacogeek.geek.exception.RequestException();

Copilot · 2026-02-19T11:37:09Z

+        try (InputStream is = getDataJumpTMDBStream(type);
+            BufferedReader reader = new BufferedReader(new InputStreamReader(is))) {
+            String line;


new InputStreamReader(is) uses the platform default charset; JSON from TMDB exports is UTF-8. Specify StandardCharsets.UTF_8 to avoid parsing issues on non-UTF-8 default platforms.

Copilot · 2026-02-19T11:37:10Z

+        if (name == null && id == null || name == "" && id == null) {
            return new MediaPage();


This check uses name == "", which compares references rather than string content; empty (or whitespace-only) names may not be detected and will fall through to the service call unexpectedly. After trimming, prefer name.isEmpty()/name.isBlank() (and simplify to something like if (id == null && (name == null || name.isBlank()))).

Copilot · 2026-02-19T11:37:10Z

+        if (name == null && id == null || name == "" && id == null) {
            return new MediaPage();


This check uses name == "", which compares references rather than string content; empty (or whitespace-only) names may not be detected and will fall through to the service call unexpectedly. After trimming, prefer name.isEmpty()/name.isBlank() (and simplify to something like if (id == null && (name == null || name.isBlank()))).

Copilot · 2026-02-19T11:37:10Z

+        if (name == null && id == null || name == "" && id == null) {
            return response;


This check uses name == "", which compares references rather than string content; empty (or whitespace-only) names may not be detected and will fall through to the service call unexpectedly. After trimming, prefer name.isEmpty()/name.isBlank() (and simplify to something like if (id == null && (name == null || name.isBlank()))).

Copilot · 2026-02-19T11:37:10Z

+        if (name == null && id == null || name == "" && id == null) {
            return new MediaPage();


This check uses name == "", which compares references rather than string content; empty (or whitespace-only) names may not be detected and will fall through to the service call unexpectedly. After trimming, prefer name.isEmpty()/name.isBlank() (and simplify to something like if (id == null && (name == null || name.isBlank()))).

Copilot · 2026-02-19T11:37:10Z

+        if (name == null && id == null || name == "" && id == null) {
            return new MediaPage();


This check uses name == "", which compares references rather than string content; empty (or whitespace-only) names may not be detected and will fall through to the service call unexpectedly. After trimming, prefer name.isEmpty()/name.isBlank() (and simplify to something like if (id == null && (name == null || name.isBlank()))).

Copilot · 2026-02-19T11:37:11Z

     *         or if the update date is null), <code>false</code> otherwise
     */
-    private static Boolean updateMediaWhenLastTimeUpdateMoreThanOneDay(MediaModel media) {
+    public static Boolean updateMediaWhenLastTimeUpdateMoreThanOneDay(MediaModel media) {


This method is now public and used as a boolean predicate, but it returns the boxed Boolean type. Prefer returning primitive boolean to avoid unnecessary boxing and the possibility of null-related issues as this becomes part of a wider API surface.

Suggested change

public static Boolean updateMediaWhenLastTimeUpdateMoreThanOneDay(MediaModel media) {

public static boolean updateMediaWhenLastTimeUpdateMoreThanOneDay(MediaModel media) {

Copilot · 2026-02-19T11:37:11Z


+import lombok.Getter;
 import org.json.simple.JSONArray;
 import org.json.simple.JSONObject;


org.json.simple.JSONObject is imported but no longer used in this file. In Java, unused imports fail compilation; remove the unused import (or reintroduce the usage if it was intended).

Suggested change

import org.json.simple.JSONObject;

vitorhugo-java added 4 commits February 18, 2026 22:27

Fix authorization role in stopJob method

7dcef56

Copilot AI review requested due to automatic review settings February 19, 2026 11:31

vitorhugo-java merged commit 56812d6 into master Feb 19, 2026
5 of 6 checks passed

Copilot started reviewing on behalf of vitorhugo-java February 19, 2026 11:31 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev#31

Dev#31
vitorhugo-java merged 4 commits intomasterfrom
dev

vitorhugo-java commented Feb 19, 2026

Uh oh!

Uh oh!

github-actions Bot commented Feb 19, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	log.error("Error reading TMDB array: {}", e.getMessage());
	log.error("Error reading TMDB array", e);
	throw new com.espacogeek.geek.exception.RequestException();

		if (name == null && id == null \|\| name == "" && id == null) {
		return new MediaPage();

		if (name == null && id == null \|\| name == "" && id == null) {
		return response;

	public static Boolean updateMediaWhenLastTimeUpdateMoreThanOneDay(MediaModel media) {
	public static boolean updateMediaWhenLastTimeUpdateMoreThanOneDay(MediaModel media) {

Conversation

vitorhugo-java commented Feb 19, 2026

Uh oh!

Uh oh!

github-actions Bot commented Feb 19, 2026

Qodana for JVM

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants