Dev by vitorhugo-java · Pull Request #32 · vitorhugo-java/SpringAPI_EspacoGeek

vitorhugo-java · 2026-02-19T18:03:49Z

No description provided.

@slf4j

Replace in-memory JSONArray readers with streaming BufferedReader-based readers for movies and series to avoid loading entire payloads into memory. Each reader now consumes an InputStream from MediaApi, parses one JSON object per line with JSONParser, tracks currentLine for checkpointing in ExecutionContext, skips already-processed lines on open, and closes the reader in close(). Added @slf4j logging and improved error logs. Also changed DelayChunkListener log level from INFO to DEBUG for the post-chunk delay message.

Add stream-based TMDB fetching and update readers: MediaApi gained updateTitlesStream(), MovieAPIImpl and TvSeriesApiImpl now return a GZIP InputStream with retry semantics. DataJumpUtils was refactored to expose getDataJumpTMDBStream(...) (returning an uncompressed GZIP InputStream) and to rebuild getDataJumpTMDBArray(...) by reading/parsing the stream line-by-line into a JSONArray with improved error handling. MovieJsonReader and SerieJsonReader now consume the JSONArray in-memory with index-based checkpointing instead of line-based BufferedReader parsing; update() persists nextIndex. Also changed DelayChunkListener logging from debug to info and expanded .gitignore entries. These changes centralize HTTP/stream handling, add better retry/error handling, and simplify JSON reader logic.

@SuppressWarnings

Replace bitwise & with logical && in MediaController input checks to correctly evaluate null/empty name conditions. In MediaServiceImpl, avoid casting Optional to Page when an id is provided: assemble a single-element list, use PageImpl and a safe pageable fallback so single-result queries behave like paged results. Add @SuppressWarnings where needed. Change artwork refresh loop to call MediaUtils.updateMediaWhenLastTimeUpdateMoreThanOneDay(...) before switching and add break statements to prevent fall-through. Make MediaUtils.updateMediaWhenLastTimeUpdateMoreThanOneDay public so it can be reused. Minor cleanup of an extraneous comment.

Copilot

Pull request overview

This PR appears to focus on improving persistence throughput (Hibernate batching + switching several entities from IDENTITY to SEQUENCE), reducing unnecessary media artwork refreshes, and adding a streaming option for TMDB “datajump” exports.

Changes:

Add Hibernate batching settings and introduce DB sequences for multiple entities (plus index drops via Flyway).
Refactor TMDB daily export fetching to support streaming (InputStream) and reuse it to build the JSONArray.
Fix paging behavior for “find by id” flows and avoid repeated artwork updates unless the media is stale.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
`src/main/resources/db/migration/V16__drop_indexes_create_seq.sql`	Creates sequences, restarts some sequences, and drops indexes as part of the move away from `IDENTITY` + improving write performance.
`src/main/resources/application.properties`	Enables Hibernate JDBC batching + ordered inserts/updates.
`src/main/java/com/espacogeek/geek/utils/MediaUtils.java`	Makes staleness-check helper public so services can gate updates.
`src/main/java/com/espacogeek/geek/utils/DataJumpUtils.java`	Adds `getDataJumpTMDBStream` and refactors array-building to read from a stream.
`src/main/java/com/espacogeek/geek/services/impl/MediaServiceImpl.java`	Fixes “find by id” paging and gates artwork updates behind the staleness check.
`src/main/java/com/espacogeek/geek/models/PeopleModel.java`	Switches ID generation to a sequence generator for batching compatibility.
`src/main/java/com/espacogeek/geek/models/MediaModel.java`	Switches ID generation to a sequence generator for batching compatibility.
`src/main/java/com/espacogeek/geek/models/ExternalReferenceModel.java`	Switches ID generation to a sequence generator for batching compatibility.
`src/main/java/com/espacogeek/geek/models/AlternativeTitleModel.java`	Switches ID generation to a sequence generator for batching compatibility.
`src/main/java/com/espacogeek/geek/data/api/impl/TvSeriesApiImpl.java`	Exposes the new streaming titles export method.
`src/main/java/com/espacogeek/geek/data/api/impl/MovieAPIImpl.java`	Exposes the new streaming titles export method.
`src/main/java/com/espacogeek/geek/data/api/MediaApi.java`	Adds a default `updateTitlesStream()` method to the API.
`src/main/java/com/espacogeek/geek/controllers/MediaController.java`	Replaces `&` with `&&` in input validation guards.
`src/main/java/com/espacogeek/geek/controllers/BatchController.java`	Fixes the required role for stopping jobs.
`src/main/java/com/espacogeek/geek/batch/DelayChunkListener.java`	Lowers log level for per-chunk delay messages.
`.gitignore`	Expands ignored env/secrets/dependency/log patterns.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-19T18:09:08Z

+ALTER SEQUENCE seq_alternative_titles RESTART WITH 122752;
+
+ALTER TABLE medias DROP INDEX idx_title;
+ALTER TABLE medias DROP INDEX idx_name;


This migration drops idx_name/idx_title, but the corresponding JPA entities still declare these indexes via @Table(indexes=...) (MediaModel has idx_name, AlternativeTitleModel has idx_title). With spring.jpa.hibernate.ddl-auto=update, Hibernate may recreate the indexes on startup, effectively undoing this migration. If the goal is to permanently remove these indexes, also remove/adjust the @Index annotations (or set ddl-auto to validate).

Suggested change

ALTER SEQUENCE seq_alternative_titles RESTART WITH 122752;

ALTER TABLE medias DROP INDEX idx_title;

ALTER TABLE medias DROP INDEX idx_name;

ALTER SEQUENCE seq_alternative_titles RESTART WITH 122752;

Copilot · 2026-02-19T18:09:08Z

+
+ALTER SEQUENCE seq_medias RESTART WITH 458830;
+ALTER SEQUENCE seq_externals_references RESTART WITH 201324;
+ALTER SEQUENCE seq_alternative_titles RESTART WITH 122752;


seq_people is created but never restarted to a value above the current max people.id_person. If the table already contains rows, the next insert using GenerationType.SEQUENCE can collide with existing IDs. Add an ALTER SEQUENCE seq_people RESTART WITH ... (ideally derived from current MAX(id_person)+1).

Suggested change

ALTER SEQUENCE seq_alternative_titles RESTART WITH 122752;

ALTER SEQUENCE seq_alternative_titles RESTART WITH 122752;

ALTER SEQUENCE seq_people RESTART WITH 1000000;

Copilot · 2026-02-19T18:09:09Z

+    @GeneratedValue(strategy = GenerationType.SEQUENCE, generator = "gen_people")
+    @SequenceGenerator(name = "gen_people", sequenceName = "seq_people", allocationSize = 50))


PeopleModel now uses @SequenceGenerator but the class doesn't import jakarta.persistence.SequenceGenerator, so this won't compile. Add the missing import (or switch to a wildcard jakarta.persistence.* import consistent with other models).

Copilot · 2026-02-19T18:09:09Z

+    @GeneratedValue(strategy = GenerationType.SEQUENCE, generator = "gen_alternative_titles")
+    @SequenceGenerator(name = "gen_alternative_titles", sequenceName = "seq_alternative_titles", allocationSize = 50)


AlternativeTitleModel now uses @SequenceGenerator but this file doesn't import jakarta.persistence.SequenceGenerator, so it won't compile. Add the missing import (or consolidate JPA imports).

Copilot · 2026-02-19T18:09:09Z

+ALTER SEQUENCE seq_externals_references RESTART WITH 201324;
+ALTER SEQUENCE seq_alternative_titles RESTART WITH 122752;
+
+ALTER TABLE medias DROP INDEX idx_title;


In this migration, idx_title is dropped from medias, but the previous migration creates idx_title on alternative_titles (see V15). Dropping it from the wrong table will fail at runtime; drop idx_title from alternative_titles instead (and keep idx_name drop on medias if intended).

Suggested change

ALTER TABLE medias DROP INDEX idx_title;

ALTER TABLE alternative_titles DROP INDEX idx_title;

Copilot · 2026-02-19T18:09:09Z

+ALTER SEQUENCE seq_medias RESTART WITH 458830;
+ALTER SEQUENCE seq_externals_references RESTART WITH 201324;
+ALTER SEQUENCE seq_alternative_titles RESTART WITH 122752;
+


The ALTER SEQUENCE ... RESTART WITH <hard-coded> values make this migration environment/data dependent. If IDs differ between environments (or future restores), this can either cause collisions or waste large ID ranges. Prefer computing MAX(id)+1 at migration time (e.g., via dynamic SQL) to make the migration deterministic.

Suggested change

ALTER SEQUENCE seq_medias RESTART WITH 458830;

ALTER SEQUENCE seq_externals_references RESTART WITH 201324;

ALTER SEQUENCE seq_alternative_titles RESTART WITH 122752;

DO $$

DECLARE

v_next_value bigint;

BEGIN

-- Set seq_medias based on current data

SELECT COALESCE(MAX(id), 0) + 1 INTO v_next_value FROM medias;

PERFORM setval('seq_medias', v_next_value, false);

-- Set seq_externals_references based on current data

SELECT COALESCE(MAX(id), 0) + 1 INTO v_next_value FROM externals_references;

PERFORM setval('seq_externals_references', v_next_value, false);

-- Set seq_alternative_titles based on current data

SELECT COALESCE(MAX(id), 0) + 1 INTO v_next_value FROM alternative_titles;

PERFORM setval('seq_alternative_titles', v_next_value, false);

END;

$$;

Copilot · 2026-02-19T18:09:10Z

+    @GeneratedValue(strategy = GenerationType.SEQUENCE, generator = "gen_medias")
+    @SequenceGenerator(name = "gen_medias", sequenceName = "seq_medias", allocationSize = 50)


MediaModel now uses @SequenceGenerator but there is no jakarta.persistence.SequenceGenerator import in this file, so it won't compile. Add the missing import (or use jakarta.persistence.*).

github-actions · 2026-02-19T18:09:19Z

Qodana for JVM

42 new problems were found

Inspection name	Severity	Problems
`Unused assignment`	🔶 Warning	16
`Constant values`	🔶 Warning	6
`String comparison using '==', instead of 'equals()'`	🔶 Warning	5
`Optional.get() is called without isPresent() check`	🔶 Warning	4
`Boxing of already boxed value`	🔶 Warning	2
`Mismatched query and update of collection`	🔶 Warning	2
`AutoCloseable used without 'try'-with-resources`	🔶 Warning	1
`Nullability and data flow problems`	🔶 Warning	1
`Result of method call ignored`	🔶 Warning	1
`'long' literal ending with 'l' instead of 'L'`	🔶 Warning	1
`Use of Optional.ofNullable with null or non-null argument`	🔶 Warning	1
`Single character alternation`	🔶 Warning	1
`'if' statement with identical branches or common parts`	◽️ Notice	1

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

Register at Qodana Cloud and configure the action
Use GitHub Code Scanning with Qodana
Host Qodana report at GitHub Pages
Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2025.3.1
        with:
          upload-result: true

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

vitorhugo-java

Fix imports and indexes

vitorhugo-java added 6 commits February 18, 2026 22:27

Fix authorization role in stopJob method

7dcef56

log debug

ce9afd8

drop indexes and create seq

43d1e0c

Copilot AI review requested due to automatic review settings February 19, 2026 18:03

Copilot started reviewing on behalf of vitorhugo-java February 19, 2026 18:04 View session

Merge branch 'master' into dev

f29c553

Copilot AI reviewed Feb 19, 2026

View reviewed changes

vitorhugo-java commented Feb 19, 2026

View reviewed changes

vitorhugo-java merged commit 89aa0c3 into master Feb 19, 2026
4 of 5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev#32

Dev#32
vitorhugo-java merged 7 commits intomasterfrom
dev

vitorhugo-java commented Feb 19, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

github-actions Bot commented Feb 19, 2026

Uh oh!

vitorhugo-java left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	ALTER SEQUENCE seq_alternative_titles RESTART WITH 122752;
	ALTER SEQUENCE seq_alternative_titles RESTART WITH 122752;
	ALTER SEQUENCE seq_people RESTART WITH 1000000;

		@GeneratedValue(strategy = GenerationType.SEQUENCE, generator = "gen_people")
		@SequenceGenerator(name = "gen_people", sequenceName = "seq_people", allocationSize = 50))

		@GeneratedValue(strategy = GenerationType.SEQUENCE, generator = "gen_alternative_titles")
		@SequenceGenerator(name = "gen_alternative_titles", sequenceName = "seq_alternative_titles", allocationSize = 50)

	ALTER TABLE medias DROP INDEX idx_title;
	ALTER TABLE alternative_titles DROP INDEX idx_title;

-ALTER SEQUENCE seq_medias RESTART WITH 458830;
-ALTER SEQUENCE seq_externals_references RESTART WITH 201324;
-ALTER SEQUENCE seq_alternative_titles RESTART WITH 122752;
+DO $$
+DECLARE
+    v_next_value bigint;
+BEGIN
+    -- Set seq_medias based on current data
+    SELECT COALESCE(MAX(id), 0) + 1 INTO v_next_value FROM medias;
+    PERFORM setval('seq_medias', v_next_value, false);
+    -- Set seq_externals_references based on current data
+    SELECT COALESCE(MAX(id), 0) + 1 INTO v_next_value FROM externals_references;
+    PERFORM setval('seq_externals_references', v_next_value, false);
+    -- Set seq_alternative_titles based on current data
+    SELECT COALESCE(MAX(id), 0) + 1 INTO v_next_value FROM alternative_titles;
+    PERFORM setval('seq_alternative_titles', v_next_value, false);
+END;
+$$;

		@GeneratedValue(strategy = GenerationType.SEQUENCE, generator = "gen_medias")
		@SequenceGenerator(name = "gen_medias", sequenceName = "seq_medias", allocationSize = 50)

Conversation

vitorhugo-java commented Feb 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Feb 19, 2026

Qodana for JVM

Uh oh!

vitorhugo-java left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants