Skip to content

WIP: Add esp32c3 supports#334

Open
xuchang-vivo wants to merge 34 commits intovivoblueos:mainfrom
xuchang-vivo:xc/seeed_xiao_esp32c3_support
Open

WIP: Add esp32c3 supports#334
xuchang-vivo wants to merge 34 commits intovivoblueos:mainfrom
xuchang-vivo:xc/seeed_xiao_esp32c3_support

Conversation

@xuchang-vivo
Copy link
Contributor

@xuchang-vivo xuchang-vivo commented Feb 24, 2026 •
edited
Loading

How to flash

espflash flash --monitor --chip esp32c3 out/seeed_xiao_esp32c3.debug/bin/shell

Already tested on esp32-c3-devkit-rust-1, also xiao esp32c3

@xuchang-vivo xuchang-vivo marked this pull request as draft February 24, 2026 06:12
@xuchang-vivo xuchang-vivo force-pushed the xc/seeed_xiao_esp32c3_support branch from cdc5420 to b17327c Compare February 25, 2026 09:18
@xuchang-vivo xuchang-vivo marked this pull request as ready for review February 27, 2026 04:20
@github-actions
Copy link

github-actions bot commented Feb 27, 2026

Job is started, see https://github.com/vivoblueos/kernel/actions/runs/22472583951.

@xuchang-vivo
Copy link
Contributor Author

xuchang-vivo commented Feb 27, 2026

build_prs #334 vivoblueos/build#60

@github-actions
Copy link

github-actions bot commented Feb 27, 2026

Job is started, see https://github.com/vivoblueos/kernel/actions/runs/22472627070.

@github-actions
Copy link

github-actions bot commented Feb 27, 2026

✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/22472583951.

@github-actions
Copy link

github-actions bot commented Feb 27, 2026

❌ Job failed. Failed jobs: build_and_check_boards (failure), see https://github.com/vivoblueos/kernel/actions/runs/22472627070.

@xuchang-vivo
Copy link
Contributor Author

xuchang-vivo commented Feb 27, 2026

build_prs #334 vivoblueos/build#60

@github-actions
Copy link

github-actions bot commented Feb 27, 2026

Job is started, see https://github.com/vivoblueos/kernel/actions/runs/22472977078.

@github-actions
Copy link

github-actions bot commented Feb 27, 2026

✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/22472977078.

lawkai-vivo
lawkai-vivo reviewed Feb 27, 2026
View reviewed changes
driver/src/interrupt_controller/mod.rs
// See the License for the specific language governing permissions and
// limitations under the License.

#[cfg(target_chip = "esp32c3")]
Copy link
Contributor

@lawkai-vivo lawkai-vivo Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the diff between target_board and target_chip?

driver/src/systimer/esp32_sys_timer.rs
}

#[inline]
pub fn clr_interrupt() {
Copy link
Contributor

@lawkai-vivo lawkai-vivo Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pub fn clr_interrupt() {
pub fn clear_interrupt() {

driver/src/systimer/esp32_sys_timer.rs
.modify(TARGET_CONF::TIMER_UNIT_SEL::CLEAR);
}

fn set_comparator_enable(enable: bool) {
Copy link
Contributor

@lawkai-vivo lawkai-vivo Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fn set_comparator_enable(enable: bool) {
fn set_comparator(enable: bool) {

lawkai-vivo
lawkai-vivo reviewed Feb 27, 2026
View reviewed changes
lawkai-vivo
lawkai-vivo reviewed Feb 27, 2026
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lawkai-vivo lawkai-vivo lawkai-vivo left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xuchang-vivo @lawkai-vivo