Skip to content

♻️ Split server baseline routes#260

Merged
Robdel12 merged 1 commit into
mainfrom
rd/cli-audit-server-baselines
May 18, 2026
Merged

♻️ Split server baseline routes#260
Robdel12 merged 1 commit into
mainfrom
rd/cli-audit-server-baselines

Conversation

@Robdel12
Copy link
Copy Markdown
Contributor

@Robdel12 Robdel12 commented May 18, 2026

Why

The local server routes for baselines, projects, screenshots, and TDD handling are core contracts between the CLI runtime, SDK clients, and the local dashboard. They should have explicit behavior and tests because small response-shape changes can break multiple entrypoints at once.

This PR isolates the baseline-facing server route cleanup from the event/router cleanup. That gives reviewers a bounded contract to inspect: request handling, project/baseline behavior, screenshot ingestion, and the TDD handler path.

What Changed

  • Tightened baseline, project, and screenshot route behavior.
  • Updated the TDD handler where it interacts with those local server routes.
  • Removed the old screenshot server service wrapper as part of moving toward the current route/server boundary.
  • Added route and handler tests around the observable server responses.

Verification

  • npm run build
  • node --test tests/server/handlers/api-handler.test.js tests/server/handlers/tdd-handler.test.js tests/server/routers/baseline.test.js tests/server/routers/projects.test.js tests/server/routers/screenshot.test.js

Stack

5/10 in the CLI audit stack.

Base: rd/cli-audit-api-review
Head: rd/cli-audit-server-baselines

@Robdel12 Robdel12 force-pushed the rd/cli-audit-api-review branch 2 times, most recently from 2826b05 to 03311ae Compare May 18, 2026 19:21
Base automatically changed from rd/cli-audit-api-review to main May 18, 2026 19:23
Pull the baseline, project, screenshot, and TDD handler route behavior into a standalone server slice.
@Robdel12 Robdel12 force-pushed the rd/cli-audit-server-baselines branch from af4cde1 to b6478de Compare May 18, 2026 19:24
@vizzly-testing
Copy link
Copy Markdown

vizzly-testing Bot commented May 18, 2026

Vizzly - Visual Test Results

CLI Reporter - 2 changes need review
Status Count
Passed 17
Changed 2
Auto-approved 17
Changes needing review (2)

dashboard-mixed-state · Firefox · 1920×1080 · 2.7% diff

dashboard-mixed-state

fullscreen-viewer · Firefox · 375×667 · 78.3% diff

fullscreen-viewer

Review changes

CLI TUI - Approved

5 comparisons, no changes detected.

View build


rd/cli-audit-server-baselines · b6478de5

@Robdel12 Robdel12 merged commit 444f567 into main May 18, 2026
29 of 30 checks passed
@Robdel12 Robdel12 deleted the rd/cli-audit-server-baselines branch May 18, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant