♻️ Split server baseline routes#260
Merged
Merged
Conversation
2826b05 to
03311ae
Compare
Pull the baseline, project, screenshot, and TDD handler route behavior into a standalone server slice.
af4cde1 to
b6478de
Compare
Vizzly - Visual Test ResultsCLI Reporter - 2 changes need review
Changes needing review (2)dashboard-mixed-state · Firefox · 1920×1080 · 2.7% diff fullscreen-viewer · Firefox · 375×667 · 78.3% diff
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Why
The local server routes for baselines, projects, screenshots, and TDD handling are core contracts between the CLI runtime, SDK clients, and the local dashboard. They should have explicit behavior and tests because small response-shape changes can break multiple entrypoints at once.
This PR isolates the baseline-facing server route cleanup from the event/router cleanup. That gives reviewers a bounded contract to inspect: request handling, project/baseline behavior, screenshot ingestion, and the TDD handler path.
What Changed
Verification
npm run buildnode --test tests/server/handlers/api-handler.test.js tests/server/handlers/tdd-handler.test.js tests/server/routers/baseline.test.js tests/server/routers/projects.test.js tests/server/routers/screenshot.test.jsStack
5/10 in the CLI audit stack.
Base:
rd/cli-audit-api-reviewHead:
rd/cli-audit-server-baselines