support language as a PluginParameter#12
Merged
vladest merged 2 commits intovladest:masterfrom Aug 14, 2017
Merged
Conversation
The road map (lyrs=m) URLs support the "hl" parameter too. If the member variable _language is passed to it, the labels on loaded tiles would change to the language defined as ISO 639x code - e.g. en-EN, de-DE, fr-FR. Signed-off-by: Lubomir I. Ivanov <neolit123@gmail.com>
Add support for the plugin parameter "googlemaps.maps.language".
If this parameter is present, the plugin user can specify
the prefered language of the tiles from QML - e.g:
PluginParameter {
name: "googlemaps.maps.language"
value: "en-US"
}
If the paremeter is not present, the class will try to fetch
the first UI langauge, as it was before this patch.
Signed-off-by: Lubomir I. Ivanov <neolit123@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hello,
this PR has a couple of patches:
if for some reason no language is set, it falls back to "en-US".
&hl=<value of _language>)