math.big: fix min i32 value bug#17775
Merged
spytheman merged 4 commits intovlang:masterfrom Mar 26, 2023
hungrybluedev:master
Merged
math.big: fix min i32 value bug#17775spytheman merged 4 commits intovlang:masterfrom hungrybluedev:master
spytheman merged 4 commits intovlang:masterfrom
hungrybluedev:master
Conversation
Contributor
hungrybluedev
commented
Mar 25, 2023
hungrybluedev
commented
- Add a special case for the minimum 32-bit signed integer value to fix math.big: Inaccurate conversion to int #17637
- Update syntax
spytheman
approved these changes
Mar 26, 2023
l1mey112
pushed a commit
to l1mey112/v
that referenced
this pull request
Jun 7, 2023
* attempt big int min value fix * cast value for correct comparison * update edge case * add one more test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.