ast, markused, checker: fix mark methods into used-list, when generics as receivers(fix #20509)#20527
Merged
spytheman merged 3 commits intovlang:masterfrom Jan 14, 2024
Merged
Conversation
spytheman
reviewed
Jan 14, 2024
spytheman
reviewed
Jan 14, 2024
Contributor
|
It is very weird that vab failed compilation on the CI to me. The code in the PR, can just protect more code to not be stripped, yet the failure indicates the opposite on first glance 🤔 . |
Contributor
Author
Yeah, it's a little weird. I'll do more research |
…s as receivers(fix vlang#20509)
spytheman
reviewed
Jan 14, 2024
Comment on lines
+521
to
+522
| // We need the receiver to be T in cgen. | ||
| // so save the concrete type to node.receiver_concrete_type |
Contributor
There was a problem hiding this comment.
That comment should be deleted imho. markused does not modify receiver_concrete_type.
spytheman
reviewed
Jan 14, 2024
spytheman
reviewed
Jan 14, 2024
Contributor
Author
|
This indicates that the comments are still not clear enough, so I'll have to edit them :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v -skip-unused run a.v: