Skip to content

v.fmt: drop newline in end comments for const#20672

Merged
spytheman merged 2 commits intovlang:masterfrom
pierrec:issue20657
Jan 27, 2024
Merged

v.fmt: drop newline in end comments for const#20672
spytheman merged 2 commits intovlang:masterfrom
pierrec:issue20657

Conversation

@pierrec
Copy link
Copy Markdown
Contributor

@pierrec pierrec commented Jan 27, 2024

Fixes #20657.

Fixes #20657.

Signed-off-by: Pierre Curto <pierre.curto@gmail.com>
@spytheman
Copy link
Copy Markdown
Contributor

Please also add the sample from the issue to a _keep.vv file under vlib/v/fmt/tests/ .

NB. a comment following a ConstDecl no longer adds a newline. This
makes it consistent whether an end of line comment exists.

Signed-off-by: Pierre Curto <pierre.curto@gmail.com>
Copy link
Copy Markdown
Contributor

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit 5a752c9 into vlang:master Jan 27, 2024
@pierrec pierrec deleted the issue20657 branch January 27, 2024 16:32
raw-bin pushed a commit to raw-bin/v that referenced this pull request Jan 29, 2024
raw-bin pushed a commit to raw-bin/v that referenced this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vfmt adds unintended? line breaks after const inline comments

2 participants