time: add http_header_string() for HTTP date/time stamps#20861
Merged
spytheman merged 1 commit intovlang:masterfrom Feb 18, 2024
davlgd:davlgd-http-header-datetime
Merged
time: add http_header_string() for HTTP date/time stamps#20861spytheman merged 1 commit intovlang:masterfrom davlgd:davlgd-http-header-datetime
spytheman merged 1 commit intovlang:masterfrom
davlgd:davlgd-http-header-datetime
Conversation
Collaborator
|
Missing doc comment for the new function. See https://github.com/vlang/v/blob/master/doc/docs.md#writing-documentation |
Add a unix time stamp to HTTP date/time stamps as defined in [RFC2616](https://www.rfc-editor.org/rfc/rfc2616#section-3.3.1), which should be used in HTTP headers such as `Expires`, `Last-Modified`, etc.
Contributor
Author
|
Sorry for that, it's been added |
spytheman
approved these changes
Feb 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a UNIX time stamp to HTTP date/time stamp as defined in RFC2616, which should be used in HTTP headers such as
Expires,Last-Modified, etc.A test has been added to
vlib/time/time_format_test.vto cover this new function.