optimizing: builtin sym marking on parser-time#22580
Merged
spytheman merged 10 commits intovlang:masterfrom Oct 21, 2024
Merged
optimizing: builtin sym marking on parser-time#22580spytheman merged 10 commits intovlang:masterfrom
spytheman merged 10 commits intovlang:masterfrom
Conversation
felipensp
changed the title
Contributor
|
Great job! |
felipensp
changed the title
spytheman
reviewed
Oct 19, 2024
Contributor
|
I could not reproduce the result on my machine :-| . Note the standard deviations for the results.
|
Contributor
|
@felipensp, can you please split the I think it can be beneficial on its own, and it may be masking the effects of the other change (which is more complex, and I suspect may be slowing things). |
felipensp
changed the title
Member
Author
Ok done. |
Contributor
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims add optimizations in as sym is checked as builtin.