Skip to content

checker: optimise identical type checking#22596

Merged
spytheman merged 2 commits intovlang:masterfrom
felipensp:opt_immediate_check_type
Oct 21, 2024
Merged

checker: optimise identical type checking#22596
spytheman merged 2 commits intovlang:masterfrom
felipensp:opt_immediate_check_type

Conversation

@felipensp
Copy link
Copy Markdown
Member

@felipensp felipensp commented Oct 20, 2024

@felipensp felipensp marked this pull request as ready for review October 20, 2024 12:30
@spytheman spytheman changed the title optimizing: immediate identical type checking checker: optimise identical type checking Oct 20, 2024
Copy link
Copy Markdown
Contributor

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

Can you please also add an early return for got_ and expected_ directly at the start of check_expected_call_arg ?

@felipensp
Copy link
Copy Markdown
Member Author

Excellent work.

Can you please also add an early return for got_ and expected_ directly at the start of check_expected_call_arg ?

yes, added.

@spytheman spytheman merged commit 9579c1f into vlang:master Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants