Skip to content

cgen: optimize caching contains_ptr return#22605

Merged
spytheman merged 1 commit intovlang:masterfrom
felipensp:opt_contains_ptr
Oct 22, 2024
Merged

cgen: optimize caching contains_ptr return#22605
spytheman merged 1 commit intovlang:masterfrom
felipensp:opt_contains_ptr

Conversation

@felipensp
Copy link
Copy Markdown
Member

@felipensp felipensp commented Oct 20, 2024

This PR add optimization to contains_ptr by caching its return.

image

new
image
old
image

Huly®: V_0.6-21054

@spytheman
Copy link
Copy Markdown
Contributor

Sorry, but the CI is broken at the moment.
I've pushed a PR to fix it, this will have to be rebased after the other PR is merged.

@esquerbatua esquerbatua added the Needs Rebase The code of the PR must be rebased over current master before it can be approved. label Oct 20, 2024
@felipensp felipensp removed the Needs Rebase The code of the PR must be rebased over current master before it can be approved. label Oct 21, 2024
Copy link
Copy Markdown
Contributor

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman marked this pull request as ready for review October 21, 2024 14:01
@spytheman spytheman merged commit cb4ddb1 into vlang:master Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants