Skip to content

cgen: cache the results of g.base_type/1 #22613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spytheman merged 3 commits into from
Oct 22, 2024
Merged

cgen: cache the results of g.base_type/1 #22613

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6760f4
opt
felipensp Oct 21, 2024
4a51bc9
move cache checking before `t := g.unwrap_generic(_t)`
spytheman Oct 22, 2024
19d4a8b
Revert "move cache checking before `t := g.unwrap_generic(_t)`"
spytheman Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions vlib/v/gen/c/cgen.v
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ mut:
sorted_global_const_names []string
file &ast.File = unsafe { nil }
table &ast.Table = unsafe { nil }
styp_cache map[ast.Type]string
unique_file_path_hash u64 // a hash of file.path, used for making auxiliary fn generation unique (like `compare_xyz`)
fn_decl &ast.FnDecl = unsafe { nil } // pointer to the FnDecl we are currently inside otherwise 0
last_fn_c_name string
Expand Down Expand Up @@ -1083,6 +1084,7 @@ pub fn (mut g Gen) write_typeof_functions() {
}

// V type to C typecc
@[inline]
fn (mut g Gen) styp(t ast.Type) string {
if t.has_flag(.option) {
// Register an optional if it's not registered yet
Expand All @@ -1096,6 +1098,9 @@ fn (mut g Gen) styp(t ast.Type) string {

fn (mut g Gen) base_type(_t ast.Type) string {
t := g.unwrap_generic(_t)
if styp := g.styp_cache[t] {
return styp
}
if g.pref.nofloat {
// TODO: compile time if for perf?
if t == ast.f32_type {
Expand All @@ -1121,6 +1126,7 @@ fn (mut g Gen) base_type(_t ast.Type) string {
if nr_muls > 0 {
styp += strings.repeat(`*`, nr_muls)
}
g.styp_cache[t] = styp
return styp
}

Expand Down