checker, cgen: fix array.delete_many() codegen#23025
Merged
spytheman merged 8 commits intovlang:masterfrom Dec 1, 2024
Merged
Conversation
Member
Le0Developer
left a comment
Le0Developer
left a comment
There was a problem hiding this comment.
How are you this fast. How can I procrastinate like this 😭
Amazing work! 👍
JalonSolov
reviewed
Nov 30, 2024
Co-authored-by: JalonSolov <JalonSolov@gmail.com>
Co-authored-by: Leo Developer <LeoDeveloper@protonmail.com>
Delta456
reviewed
Dec 1, 2024
Member
Delta456
left a comment
Delta456
left a comment
There was a problem hiding this comment.
Good work!
I was wondering if we can also add checker tests for this.
Contributor
|
I think checker tests can be valuable as well (to prevent future regressions for invalid usages) but the current PR is already preventing a cgen problem for a valid usage, and I think it can be merged now, and the checker tests for its errors, can be added later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #23024
Huly®: V_0.6-21466