Skip to content

cgen: fix update expr with embed fixed array multi dimensions#23049

Merged
spytheman merged 1 commit intovlang:masterfrom
felipensp:fix_array_fixed_2_dims_embed
Dec 3, 2024
Merged

cgen: fix update expr with embed fixed array multi dimensions#23049
spytheman merged 1 commit intovlang:masterfrom
felipensp:fix_array_fixed_2_dims_embed

Conversation

@felipensp
Copy link
Copy Markdown
Member

@felipensp felipensp commented Dec 2, 2024

@felipensp felipensp marked this pull request as ready for review December 2, 2024 13:56
Copy link
Copy Markdown
Member

@Delta456 Delta456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

Copy link
Copy Markdown
Contributor

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.
I liked the reduction of code, by extracting the common case into a function very much.

@spytheman spytheman merged commit d3b5dbd into vlang:master Dec 3, 2024
@felipensp felipensp deleted the fix_array_fixed_2_dims_embed branch December 4, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cloning heap struct instance with spread operator creates invalid copy.

3 participants