v: allow option array element comparison == and !=#23113
Merged
spytheman merged 2 commits intovlang:masterfrom Dec 9, 2024
Merged
v: allow option array element comparison == and !=#23113spytheman merged 2 commits intovlang:masterfrom
== and !=#23113spytheman merged 2 commits intovlang:masterfrom
Conversation
spytheman
reviewed
Dec 9, 2024
Contributor
|
I've merged it without the additional tests for now, since I do not want to wait for their CI, before making a release, but I really do think that the tests should be added. There were times in the past already, where the implementation for the options and generics types had hysteresis, and things that normally worked in isolation, broke when used in the same function due to that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #23108
Huly®: V_0.6-21550