math: use libc wrappers for math.log2/1, math.log10/1, math.log1p/1 and math.log_b/1. Make assert math.log10(10) == 1.0 pass.#23129
Merged
spytheman merged 1 commit intovlang:masterfrom Dec 11, 2024
Conversation
…nd math.log_b/1. Make `assert math.log10(10) == 1.0` pass.
Contributor
Author
|
That imho needs more investigation, by people with background in Numerical Analysis. To me, it seems that the pure V approximation in https://github.com/vlang/v/blob/master/vlib/math/log.v#L122 may need tweaking of some consts, or an algorithmic adjustment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem was discovered by @Le0Developer, in https://github.com/vlang/adventofcode/pull/71/files#diff-aa6c500b5be6ff2273db2523c71ebe791319dc63602e3857013e33cee163e23cR14 .
Huly®: V_0.6-21566