Skip to content

v: fix all memleaks to enable memleak detection#23200

Merged
spytheman merged 18 commits intovlang:masterfrom
felipensp:fix_several_memleaks
Dec 20, 2024
Merged

v: fix all memleaks to enable memleak detection#23200
spytheman merged 18 commits intovlang:masterfrom
felipensp:fix_several_memleaks

Conversation

@felipensp
Copy link
Copy Markdown
Member

@felipensp felipensp commented Dec 18, 2024

This PR aims to fix all memleak found on sanitize tests for enabling detect_leaks=1

PS: Some sqlite test were fixed because indirect leak was spotted on gcc sanitizer.

Huly®: V_0.6-21637

@felipensp felipensp marked this pull request as ready for review December 18, 2024 14:02
Comment thread .github/workflows/sanitized_ci.yml Outdated
Comment thread vlib/crypto/ecdsa/ecdsa_test.v Outdated
Copy link
Copy Markdown
Contributor

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.
Thank you 🙇🏻‍♂️.

@spytheman
Copy link
Copy Markdown
Contributor

I think we may have to skip the orm tests again for now (the ones that use sqlite) 🤔 .

@felipensp
Copy link
Copy Markdown
Member Author

I think we may have to skip the orm tests again for now (the ones that use sqlite) 🤔 .

Ok, I'll treat the known cases in the .suppressions file.

@felipensp
Copy link
Copy Markdown
Member Author

felipensp commented Dec 19, 2024

Some sqlite tests were fixed because indirect leak was spotted on gcc sanitizer.

@spytheman spytheman merged commit b077219 into vlang:master Dec 20, 2024
@felipensp felipensp deleted the fix_several_memleaks branch December 20, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants